Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): avoid vue-router warning with routeRule redirect #25391

Merged
merged 1 commit into from Jan 29, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 23, 2024

πŸ”— Linked issue

resolves #24112

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When using nitro route rules, we support client-side handling of redirects with vue-router (as well as nitro on server side). However, there's still an error message printed in the console.

This PR adds a stub component (a bare object) for these routes, so that the error is suppressed.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Jan 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manniL
Copy link
Member

manniL commented Jan 23, 2024

A bit unrelated, but before I forget it: We should also look into fetching payloads (prerendering + payloadExtraction) when the page has a redirect.

@danielroe
Copy link
Member Author

A bit unrelated, but before I forget it: We should also look into fetching payloads (prerendering + payloadExtraction) when the page has a redirect.

We I think should already skip fetching payloads for redirected paths:

return !!rules.prerender && !rules.redirect

@manniL
Copy link
Member

manniL commented Jan 23, 2024

@danielroe sorry, I meant a redirect via definePageMeta (making it totally unrelated πŸ˜‚).

@danielroe danielroe merged commit b5853c9 into main Jan 29, 2024
36 checks passed
@danielroe danielroe deleted the fix/route-rule-warning branch January 29, 2024 11:07
@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue Router "no match found" warning when using path from routeRules in NuxtLink
2 participants