Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): extract styles for shared chunks #25455

Merged
merged 12 commits into from Jan 28, 2024
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 26, 2024

πŸ”— Linked issue

closes #25394

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We weren't extracting styles for chunks without a facadeModuleId, but it's safe to do so for individual module ids. This is a PR that simply adds these additional module ids to be extracted, as long as they are Vue files (which are the ones tracked in ssr context).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • added tests

Copy link

stackblitz bot commented Jan 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe self-assigned this Jan 26, 2024
Comment on lines +1955 to +1959
{
"href": "/_nuxt/components/SharedComponent.vue?vue&type=style&index=0&scoped=3ee84738&lang.css",
"key": "island-link",
"rel": "stylesheet",
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a product of changes in the code; this is vite behaviour for adding a shared component (also on main).

@danielroe
Copy link
Member Author

Seems that this PR also resolves issue in #25394 (added regression test from that PR here as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants