New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): extract styles for shared chunks #25455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
huang-julien
approved these changes
Jan 26, 2024
danielroe
commented
Jan 27, 2024
Comment on lines
+1955
to
+1959
{ | ||
"href": "/_nuxt/components/SharedComponent.vue?vue&type=style&index=0&scoped=3ee84738&lang.css", | ||
"key": "island-link", | ||
"rel": "stylesheet", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a product of changes in the code; this is vite behaviour for adding a shared component (also on main).
Seems that this PR also resolves issue in #25394 (added regression test from that PR here as well). |
huang-julien
approved these changes
Jan 28, 2024
Merged
This was referenced Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
defineAsyncComponent
Β #25451closes #25394
β Type of change
π Description
We weren't extracting styles for chunks without a
facadeModuleId
, but it's safe to do so for individual module ids. This is a PR that simply adds these additional module ids to be extracted, as long as they are Vue files (which are the ones tracked in ssr context).π Checklist