Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): improve return type of useRequestEvent #25480

Merged
merged 1 commit into from Jan 29, 2024
Merged

fix(nuxt): improve return type of useRequestEvent #25480

merged 1 commit into from Jan 29, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #25442

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This ensures that useRequestEvent passes down the undefined type of the event (as well as the default generic).

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 January 29, 2024 11:03
@danielroe danielroe self-assigned this Jan 29, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio Nuxt Studio
Copy link

nuxt-studio bot commented Jan 29, 2024

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 92f2d30

@danielroe danielroe merged commit 7342148 into main Jan 29, 2024
36 of 37 checks passed
@danielroe danielroe deleted the fix/request-event branch January 29, 2024 11:48
This was referenced Jan 29, 2024
Merged
Closed
@pi0 pi0 mentioned this pull request Jan 29, 2024
Closed
@danielroe danielroe mentioned this pull request Jan 30, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor-bug types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useRequestEvent return type should be H3Event | undefined
1 participant
@danielroe