ci: fix playwright cache

[BobbieGoede]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I think playwright cache in the ci action has been ignored (always downloadin & installing) since replacing playwright with playwright-core. This (should) fix the cache.

Main thing I wanted to fix is that the action sometimes fails running this command:

$env:PLAYWRIGHT_VERSION="$(pnpm ls --depth 0 --json -w playwright | jq --raw-output '.[0].unsavedDependencies[\"playwright\"].version')"

With the following error:

jq: error: syntax error, unexpected INVALID_CHARACTER (Windows cmd shell quoting issues?) at <top-level>, line 1:
.[0].unsavedDependencies[\"playwright\"].version                         
jq: 1 compile error

Honestly I'm not sure why this command doesn't consistently error, and when it doesn't error it resolves to null, and I think that since there is no local playwright installed with version null it downloads and installs instead. This will likely reduce flakiness for the erroring actions.

📝 Checklist

• I have linked an issue or discussion.
• I have added tests (if possible).
• I have updated the documentation accordingly.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[BobbieGoede]

Maybe it should still be using unsavedDependencies instead of devDependencies?

[BobbieGoede]

Looks like caching is working now for the Ubuntu actions, but not quite for Windows.. Not sure why that is, at least playwright version parsing is working for Windows now as well.

[BobbieGoede]

Actually caching should work for Windows actions as well, I think the cache just still unset on the first run 😅