Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: retry flaky test when running in Windows with Webpack #25536

Merged

Conversation

BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Jan 31, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since we know that it is flaky and it does succeed after retries, this is preferable over triggering the retry manually. This possibly needs to include the following test "expect scroll to top on nested pages" as well, but I haven't tested its flakiness.

While retries are not ideal, it's better/faster than rerunning the entire job. Hopefully we can find the source of its flakiness someday or someone manages to provide a reproduction with the issue.

Besides this scroll to top test, test/basic.test.ts > component islands > test client-side navigation may be the last remaining flaky test.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Jan 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit f3c1c3e into nuxt:main Jan 31, 2024
36 checks passed
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants