New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): NuxtLink
no default rel for relative external links
#25600
Merged
+22
β9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
β Live Preview ready!
|
4 tasks
harlan-zw
changed the title
fix(nuxt): apply default
fix(nuxt): Feb 3, 2024
NuxtLink
rel noreferrer
to absolute urlsNuxtLink
no default rel for relative external links
danielroe
reviewed
Feb 4, 2024
danielroe
reviewed
Feb 4, 2024
danielroe
reviewed
Feb 4, 2024
danielroe
reviewed
Feb 4, 2024
danielroe
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Relates to #25532
β Type of change
π Description
The default
rel
tag we apply toexternal
NuxtLink's is quite interesting, here are some details about it if you don't know:noopener
, providing both are not required. I'd just usenoreferrer
but it's probably worth keeping consistency with larger sites in this case (i.e GitHub / Twitter still uses both).target="_blank"
in browsers since 2021, so providing all together will not be necessary at some point.Anyway to the point of this PR, it's to fix an edge case where it's applied when not needed and document this logic.
Wasn't sure whether to support relative links that open in a separate window context for extra security, interested to hear others' thoughts (i.e you're hosting an untrusted app on your domain).
π Checklist