Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): remove $ from generated id in useId #25615

Merged
merged 2 commits into from Feb 4, 2024
Merged

fix(nuxt): remove $ from generated id in useId #25615

merged 2 commits into from Feb 4, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #25572

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is a quick hotfix to remove generated $ from key provided to useId.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug label Feb 4, 2024
@danielroe danielroe self-assigned this Feb 4, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Feb 4, 2024
@danielroe danielroe merged commit 82173ad into main Feb 4, 2024
35 checks passed
@danielroe danielroe deleted the fix/remove-dollar branch February 4, 2024 22:13
This was referenced Feb 4, 2024
Closed
Merged
manniL pushed a commit that referenced this pull request Feb 18, 2024
@danielroe @manniL
fix(nuxt): remove $ from generated id in useId (#25615)
2fcf867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dollar sign ($) in id attribute generated by useId composable breaks validity when used in svg.
1 participant
@danielroe