Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): warn if inheritAttrs: false is set when using useId #25616

Merged
merged 2 commits into from Feb 5, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #25605

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a warning when inheritAttrs: false is set in a component where we are using useId. This is not compatible with our current implementation.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug label Feb 4, 2024
@danielroe danielroe requested a review from manniL February 4, 2024 22:06
Copy link

stackblitz bot commented Feb 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe self-assigned this Feb 4, 2024
@github-actions github-actions bot added the 3.x label Feb 4, 2024
@danielroe danielroe merged commit 8705aed into main Feb 5, 2024
34 checks passed
@danielroe danielroe deleted the fix/attrs-warn-id branch February 5, 2024 10:31
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useId bug when inheritAttrs: false
3 participants