perf(nuxt): don't check for prerendered route in dev for server page #26061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
huang-julien
changed the title
DamianGlowala
changed the title
danielroe
approved these changes
Mar 4, 2024
danielroe
reviewed
Mar 4, 2024
| @@ -42,7 +42,7 @@ export const createIslandPage = (name: string) => { | |||
| }) | |||
|
|
|||
| const route = useRoute() | |||
| const path = await isPrerendered(route.path) ? route.path : route.fullPath.replace(/#.*$/, '') | |||
| const path = !import.meta.dev && await isPrerendered(route.path) ? route.path : route.fullPath.replace(/#.*$/, '') | |||
There was a problem hiding this comment.
we could also update this in the isPrerendered function.
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Hey 👋 this PR fixes #24954 (comment)
There's no need to fetch the manifest for prerender in dev mode. There's also another issue for the
isPrerenderedhelper in dev mode fixedby #26063❓ Type of change
📚 Description
📝 Checklist