Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): pass path to jiti and not file URL #27252

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/test-utils#848

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Discovered in nuxt/test-utils#848, we were passing fileURL via dirname -> jiti, which was yielding an invalid path of file:\\\D:\...\... on windows machines. Not sure of the cause at the moment, but it seems like we probably should be passing a file path rather than URL anyway.

cc: @pi0

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented May 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 5ce738d into main May 16, 2024
61 checks passed
@danielroe danielroe deleted the fix/file-url-jiti branch May 16, 2024 15:11
@github-actions github-actions bot mentioned this pull request May 16, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant