Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): add dev reviver for VNode and do not deduplicate server/client logs #27309

Merged
merged 6 commits into from
May 23, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #27130

📚 Description

Because Vue calls console.warn when stringifying a Vue component, it will trigger an infinite loop if consola is wrapping console when stringifying a Vue warning. Non-Nuxt issue/example here: unjs/consola#298.

For now, given how common it is for Vue to warn about non-existing components (a typo is sufficient!) I think the best solution is just to remove the ability to deduplicate server/client logs, which means users may get duplicate logs.

We can revisit later if we implement loop protection upstream.

I've also added another reducer/revivers only for logs, which handles VNode type. Other ideas to improve DX would be welcome.

Copy link

stackblitz bot commented May 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title feat(nuxt): add dev revivers for VNode/Component feat(nuxt): add dev reviver for VNode and do not deduplicate server/client logs May 22, 2024
@danielroe danielroe requested a review from atinux May 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite warn and memory crash when updating nuxt from 3.10 to 3.11
2 participants