Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: force if braces, no lonely ifs and add store.js #3685

Merged
merged 2 commits into from
Aug 10, 2018
Merged

lint: force if braces, no lonely ifs and add store.js #3685

merged 2 commits into from
Aug 10, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Aug 10, 2018 •
edited

  • Force curly braces for one-line control elements (eg. if (true) return "A" => if(true) { return "A" }

  • Prohibit single if/else in else branch

f.ex.:

if(true){}
else{

  if(false){}
  else{}
}
  • unignored lib/app/store.js

clarkdo
clarkdo approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkdo clarkdo merged commit 1ec5cf7 into nuxt:dev Aug 10, 2018
@manniL manniL deleted the lint-force-if-brackets branch August 11, 2018 06:57
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clarkdo clarkdo clarkdo approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manniL @clarkdo @danielroe