New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: warn on unknown mode #4303
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4303 +/- ##
==========================================
+ Coverage 90.97% 90.98% +<.01%
==========================================
Files 56 56
Lines 1828 1830 +2
Branches 457 459 +2
==========================================
+ Hits 1663 1665 +2
Misses 154 154
Partials 11 11
Continue to review full report at Codecov.
|
43fe1e6
to
ed61ddf
Compare
Avoids an infinite loading loop on unknown mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice idea. recently in discord #russian channel someone asked that he used mode: 'static' and was wondering why it dont generate static html files :)
@aldarund I was also caught in this pitfall when I was trying out new |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Warn if mode is neither
spa
noruniversal
.Types of changes