Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn on unknown mode #4303

Merged
merged 9 commits into from Nov 11, 2018
Merged

chore: warn on unknown mode #4303

merged 9 commits into from Nov 11, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Nov 9, 2018

Warn if mode is neither spa nor universal.

Types of changes

  • Warning

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #4303 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4303      +/-   ##
==========================================
+ Coverage   90.97%   90.98%   +<.01%     
==========================================
  Files          56       56              
  Lines        1828     1830       +2     
  Branches      457      459       +2     
==========================================
+ Hits         1663     1665       +2     
  Misses        154      154              
  Partials       11       11
Impacted Files Coverage Δ
packages/config/src/options.js 94.53% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b1998...5092709. Read the comment docs.

packages/cli/src/utils/index.js Outdated Show resolved Hide resolved
Avoids an infinite loading loop on unknown mode
Copy link

@aldarund aldarund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea. recently in discord #russian channel someone asked that he used mode: 'static' and was wondering why it dont generate static html files :)

@pi0 pi0 merged commit d280bd8 into dev Nov 11, 2018
@pi0 pi0 deleted the chore-warn-on-unknown-mode branch November 11, 2018 11:21
@AndrewBogdanovTSS
Copy link

@aldarund I was also caught in this pitfall when I was trying out new modern mode. For some reason I decided that it should be specified like mode: 'modern' and since I didn't get any warnings/nor errors during the build - I was convinced that it's the right way to go, although nothing been working in the browser. It just was an endless wait for the response

@lock
Copy link

lock bot commented Dec 12, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants