Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: disable compressor if set to false/undefined #4381

Merged
merged 1 commit into from Nov 21, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Nov 21, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Improvement

Description

If compressor it falsy, disable it

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 changed the base branch from 2.x to dev November 21, 2018 13:45
@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

Merging #4381 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4381      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files          56       56              
  Lines        1910     1911       +1     
  Branches      480      481       +1     
==========================================
+ Hits         1743     1744       +1     
  Misses        154      154              
  Partials       13       13
Impacted Files Coverage Δ
packages/server/src/server.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83b567...ad2ba0a. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Nov 21, 2018

Rebuilding azure

@pi0 pi0 merged commit e4140ce into dev Nov 21, 2018
@pi0 pi0 deleted the improve/disable-compression branch November 21, 2018 14:33
@lock
Copy link

lock bot commented Dec 21, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 21, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants