Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): allow passing custom props to error function #4462

Merged
merged 4 commits into from Nov 30, 2018
Merged

Conversation

aldarund
Copy link

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #4460

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #4462 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4462   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          56       56           
  Lines        1963     1963           
  Branches      487      487           
=======================================
  Hits         1795     1795           
  Misses        156      156           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d78027...dc98d01. Read the comment docs.

@aldarund aldarund self-assigned this Nov 30, 2018
clarkdo
clarkdo previously approved these changes Nov 30, 2018
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using spread instead of assign?

@pi0 pi0 merged commit a6fed0a into dev Nov 30, 2018
@pi0 pi0 deleted the err-custom-params branch November 30, 2018 19:15
pi0 pushed a commit that referenced this pull request Dec 9, 2018
@lock
Copy link

lock bot commented Dec 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 30, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error({ .. }) - cannot pass custom properties to error function after 2.2.0
5 participants