Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): generate client source map if devtool set in extend of … #4515

Merged
merged 3 commits into from Dec 10, 2018

Conversation

aldarund
Copy link

…config

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

make source map generated based on devtool value that could be set in extend

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #4515 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4515      +/-   ##
==========================================
+ Coverage   91.08%   91.11%   +0.02%     
==========================================
  Files          61       61              
  Lines        2177     2183       +6     
  Branches      523      526       +3     
==========================================
+ Hits         1983     1989       +6     
  Misses        176      176              
  Partials       18       18
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 96.42% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07c27a...e52858d. Read the comment docs.

@aldarund aldarund requested review from manniL, clarkdo and pi0 and removed request for manniL and clarkdo December 10, 2018 20:16
@aldarund aldarund self-assigned this Dec 10, 2018
pi0
pi0 previously approved these changes Dec 10, 2018
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than comments, LGTM

@pi0 pi0 merged commit 33edef2 into dev Dec 10, 2018
@pi0 pi0 deleted the source-map branch December 10, 2018 21:34
@lock
Copy link

lock bot commented Jan 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants