Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HardSourceWebpackPlugin #4527

Merged
merged 2 commits into from
Dec 11, 2018
Merged

feat: add HardSourceWebpackPlugin #4527

merged 2 commits into from
Dec 11, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Dec 11, 2018

Adds experimental support for https://github.com/mzgoddard/hard-source-webpack-plugin (disabled by default)

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #4107

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #4527 into dev will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4527      +/-   ##
==========================================
- Coverage   91.13%   91.09%   -0.04%     
==========================================
  Files          61       61              
  Lines        2188     2190       +2     
  Branches      527      528       +1     
==========================================
+ Hits         1994     1995       +1     
- Misses        176      177       +1     
  Partials       18       18
Impacted Files Coverage Δ
packages/config/src/config/build.js 85.71% <ø> (ø) ⬆️
packages/webpack/src/config/base.js 95.34% <50%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1505197...dfe435c. Read the comment docs.

pi0
pi0 previously approved these changes Dec 11, 2018
packages/webpack/src/config/base.js Outdated Show resolved Hide resolved
@aldarund
Copy link

Heh, i wanted to add it too since its have fixed issues with recent webpack recently . but here u are :)

aldarund
aldarund previously approved these changes Dec 11, 2018
@manniL
Copy link
Member Author

manniL commented Dec 11, 2018

@aldarund Sorry 🙈

clarkdo
clarkdo previously approved these changes Dec 11, 2018
@manniL manniL dismissed stale reviews from clarkdo, aldarund, and pi0 via dfe435c December 11, 2018 20:34
@manniL
Copy link
Member Author

manniL commented Dec 11, 2018

Done 👍

@pi0 pi0 merged commit c6d820a into dev Dec 11, 2018
@pi0 pi0 deleted the feat/hard-source-wp-plugin branch December 11, 2018 20:49
@manniL manniL mentioned this pull request Dec 23, 2018
22 tasks
@lock
Copy link

lock bot commented Jan 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HardSourceWebpackPlugin
6 participants