feat: allow scrollToTop to be explicitly disabled #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to manually override scroll position. For instance to offset scroll position before a transition.
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #4564 +/- ##
=====================================
Coverage 91.1% 91.1%
=====================================
Files 61 61
Lines 2204 2204
Branches 534 534
=====================================
Hits 2008 2008
Misses 178 178
Partials 18 18Continue to review full report at Codecov.
|
pi0
approved these changes
Dec 16, 2018
|
Is a change in the docs necessary? |
|
@manniL yep, will do! |
|
Thanks @galvez ! Holidays got in the way for me I'm afraid 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up #4170 -- debugged and added test.