Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no false positives for plugins with index.js #4714

Merged
merged 4 commits into from Jan 8, 2019

Conversation

manniL
Copy link
Member

@manniL manniL commented Jan 8, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #4713

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@manniL manniL changed the title test: let them fail by adding faulty example fix: no false positives for plugins with index.js Jan 8, 2019
@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #4714 into dev will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4714      +/-   ##
==========================================
- Coverage   90.45%   90.43%   -0.03%     
==========================================
  Files          67       67              
  Lines        2253     2258       +5     
  Branches      555      556       +1     
==========================================
+ Hits         2038     2042       +4     
- Misses        194      195       +1     
  Partials       21       21
Impacted Files Coverage Δ
packages/builder/src/builder.js 93.53% <100%> (ø) ⬆️
packages/utils/src/resolve.js 94% <80%> (-1.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf76d9...b18f468. Read the comment docs.

@manniL manniL requested a review from a team January 8, 2019 18:58
@pi0 pi0 merged commit eef2af3 into dev Jan 8, 2019
@pi0 pi0 deleted the fix-plugins/folder-index-false-positive branch January 8, 2019 19:26
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nuxt-edge] Wrong warning when plugin without extension is used
4 participants