Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit tests for generator #4857

Merged
merged 10 commits into from
Jan 29, 2019
Merged

test: unit tests for generator #4857

merged 10 commits into from
Jan 29, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jan 25, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 January 25, 2019 13:42
@clarkdo clarkdo requested a review from a team January 25, 2019 14:31
@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #4857 into dev will increase coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4857      +/-   ##
==========================================
+ Coverage   91.27%   91.66%   +0.38%     
==========================================
  Files          72       72              
  Lines        2395     2399       +4     
  Branches      592      592              
==========================================
+ Hits         2186     2199      +13     
+ Misses        191      182       -9     
  Partials       18       18
Impacted Files Coverage Δ
packages/generator/src/generator.js 100% <100%> (+8.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59be77a...14dea74. Read the comment docs.

@clarkdo clarkdo changed the title feat(test): unit tests for generator test: unit tests for generator Jan 29, 2019
@clarkdo clarkdo merged commit e22a282 into nuxt:dev Jan 29, 2019
@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the feat/test-generator branch April 2, 2019 13:20
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants