Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): rebase on latest stable nuxt version #4874

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

manniL
Copy link
Member

@manniL manniL commented Jan 29, 2019

Examples should reflect the current stable Nuxt version (instead of bleeding edge builds)

@manniL manniL mentioned this pull request Jan 29, 2019
7 tasks
@codecov-io
Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #4874 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4874   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          71       71           
  Lines        2360     2360           
  Branches      583      583           
=======================================
  Hits         2157     2157           
  Misses        185      185           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a303ea8...4916166. Read the comment docs.

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Jan 29, 2019

For typescript examples, todo list :

  • Move from nuxt-ts-edge to nuxt-ts in package.json
  • Extends @nuxt/typescript instead of @nuxt/typescript-edge in tsconfig.json
  • Change types array : @nuxt/vue-app instead of @nuxt/vue-app-edge

pi0
pi0 previously approved these changes Jan 29, 2019
@pi0 pi0 merged commit 47898fb into dev Feb 1, 2019
@pi0 pi0 deleted the chore/base-examples-on-stable-nuxt-version branch February 1, 2019 13:06
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants