refactor: typos #4922
Merged
refactor: typos #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4922 +/- ##
==========================================
- Coverage 91.87% 91.71% -0.16%
==========================================
Files 73 73
Lines 2412 2414 +2
Branches 593 594 +1
==========================================
- Hits 2216 2214 -2
- Misses 178 182 +4
Partials 18 18
Continue to review full report at Codecov.
|
pi0
reviewed
Feb 1, 2019
| @@ -111,7 +111,7 @@ export default class Resolver { | |||
| throw new Error(`Cannot resolve "${path}" from "${resolvedPath}"`) | |||
| } | |||
|
|
|||
| requireModule(path, { esm, useESM = esm, alias, isAlias = alias, intropDefault } = {}) { | |||
| requireModule(path, { esm, useESM = esm, alias, isAlias = alias, intropDefault, interopDefault = intropDefault } = {}) { | |||
There was a problem hiding this comment.
@pi0 to avoid breaking changes, same as isAlias = alias and so on
There was a problem hiding this comment.
I don't think anybody uses them. Should be fine as not documented. Anyway let's keep it :)
pi0
previously approved these changes
Feb 1, 2019
pi0
approved these changes
Feb 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuation of #4904