Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use puppeteer-core #4929

Merged
merged 2 commits into from
Feb 3, 2019
Merged

chore: use puppeteer-core #4929

merged 2 commits into from
Feb 3, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 2, 2019

  • Use puppeteer-core instead of puppeteer and update to latest.
  • puppeteer package always downloads google chrome (~200MB) and even if we use cache it is passed to all CI steps unnecessarily.
  • We use circleci/node:latest-browsers which has chrome pre-installed
  • Faster local repository installs time and instead auto-detect locally installed chrome/chromium path
  • Prevent breaking change of puppeteer 1.12.1 by using chrome-stable of circle CI image

Before: (took 07:02)

image

After: (took 06:04)

image

@pi0 pi0 requested review from clarkdo and a team February 2, 2019 11:20
@codecov-io
Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #4929 into dev will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4929      +/-   ##
==========================================
+ Coverage   91.67%   91.75%   +0.08%     
==========================================
  Files          73       73              
  Lines        2414     2414              
  Branches      594      594              
==========================================
+ Hits         2213     2215       +2     
+ Misses        183      181       -2     
  Partials       18       18
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 95.65% <0%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdec133...0aa81e9. Read the comment docs.

@pi0 pi0 merged commit 940a36f into dev Feb 3, 2019
@pi0 pi0 deleted the chore/use-puppeteer-core branch February 3, 2019 06:36
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants