Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): change cli.test to be more accurate #4957

Merged
merged 4 commits into from
Feb 6, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Feb 5, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 February 5, 2019 12:15
@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #4957 into dev will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4957      +/-   ##
==========================================
+ Coverage   92.93%   92.97%   +0.04%     
==========================================
  Files          73       73              
  Lines        2421     2421              
  Branches      595      595              
==========================================
+ Hits         2250     2251       +1     
+ Misses        156      155       -1     
  Partials       15       15
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 96.19% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3147823...0ae4d5e. Read the comment docs.

@clarkdo clarkdo added the WIP label Feb 5, 2019
@clarkdo clarkdo removed the request for review from pi0 February 5, 2019 12:32
@clarkdo clarkdo self-assigned this Feb 5, 2019
@manniL manniL changed the title refactor(test): change cli.test to be mare accurate refactor(test): change cli.test to be more accurate Feb 5, 2019
test/unit/cli.test.js Outdated Show resolved Hide resolved
@clarkdo clarkdo requested a review from pi0 February 5, 2019 17:00
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Refactor!

@pi0 pi0 merged commit 68f6880 into nuxt:dev Feb 6, 2019
@manniL manniL removed the WIP label Feb 6, 2019
@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the cli-test branch April 2, 2019 13:05
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants