Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable "analyze" for nuxt generate #4975

Merged
merged 2 commits into from
Feb 7, 2019
Merged

fix: disable "analyze" for nuxt generate #4975

merged 2 commits into from
Feb 7, 2019

Conversation

manniL
Copy link
Member

@manniL manniL commented Feb 7, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Analyzing builds should only happen on nuxt build as you shouldn't use the bundle for prod/deployment anyway. I suggest to set build.analyze to false when using nuxt generate

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@manniL manniL self-assigned this Feb 7, 2019
@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #4975 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4975      +/-   ##
==========================================
+ Coverage   92.28%   92.29%   +<.01%     
==========================================
  Files          74       74              
  Lines        2450     2453       +3     
  Branches      603      604       +1     
==========================================
+ Hits         2261     2264       +3     
  Misses        169      169              
  Partials       20       20
Impacted Files Coverage Δ
packages/cli/src/commands/generate.js 86.66% <100%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03dafb...60bb540. Read the comment docs.

@pi0 pi0 merged commit 574a2eb into dev Feb 7, 2019
@pi0 pi0 deleted the fix/analyze-generate branch February 7, 2019 15:00
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants