Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use spread syntax for plugin push #4976

Merged
merged 1 commit into from
Feb 7, 2019
Merged

refactor: use spread syntax for plugin push #4976

merged 1 commit into from
Feb 7, 2019

Conversation

manniL
Copy link
Member

@manniL manniL commented Feb 7, 2019

Types of changes

  • Refactor

Checklist:

  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #4976 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4976      +/-   ##
==========================================
+ Coverage   92.28%   92.32%   +0.04%     
==========================================
  Files          74       74              
  Lines        2450     2450              
  Branches      603      603              
==========================================
+ Hits         2261     2262       +1     
+ Misses        169      168       -1     
  Partials       20       20
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 95.45% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 95.1% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03dafb...24832e0. Read the comment docs.

@pi0 pi0 merged commit 31cb187 into dev Feb 7, 2019
@manniL manniL deleted the refactor/array-push branch February 7, 2019 15:56
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants