Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example(jest-puppeteer): fix package .json #4997

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

acravenho
Copy link

While adding Jest and Puppeteer to my project I noticed that the example package.json file contained a small bug which would causing the following error:

[FATAL] No build files found, please run `nuxt build` before launching `nuxt start`

The simple fix was to add another & sign between nuxt build and nuxt start

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The change would fix the jest-puppeteer example folder for any future users who may want to use this as an example.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #4997 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4997      +/-   ##
==========================================
- Coverage   92.27%   92.23%   -0.05%     
==========================================
  Files          74       74              
  Lines        2472     2472              
  Branches      608      608              
==========================================
- Hits         2281     2280       -1     
- Misses        171      172       +1     
  Partials       20       20
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 94.81% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e083c38...261bc86. Read the comment docs.

@manniL manniL changed the title Add Extra Ampersand Before Nuxt Start example(jest-puppeteer): fix package .json Feb 10, 2019
@manniL
Copy link
Member

manniL commented Feb 10, 2019

Thank you ☺️

@pi0 pi0 merged commit dfc8dd5 into nuxt:dev Feb 10, 2019
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants