Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(webpack): use futureEmitAssets #5003

Merged
merged 2 commits into from
Feb 11, 2019
Merged

perf(webpack): use futureEmitAssets #5003

merged 2 commits into from
Feb 11, 2019

Conversation

manniL
Copy link
Member

@manniL manniL commented Feb 11, 2019

Implement webpack/webpack#8642

Types of changes

  • New feature (a non-breaking change which adds functionality)

Description

New option output.futureEmitAssets allows to opt-in to the new way of emitting assets which allows to free memory of Sources with the trade-off of disallowing reading asset content after emitting

Maybe we should make that configurable though 馃 when problems arise

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@manniL manniL changed the title feat: use new futureEmitAssets flag feat(webpack): use new futureEmitAssets flag Feb 11, 2019
@pi0
Copy link
Member

pi0 commented Feb 11, 2019

@manniL Great discovery. Let's see if tests are passing. We can fully test it in edge.

@pi0 pi0 changed the title feat(webpack): use new futureEmitAssets flag perf(webpack): use new futureEmitAssets flag Feb 11, 2019
@pi0 pi0 changed the title perf(webpack): use new futureEmitAssets flag perf(webpack): use futureEmitAssets Feb 11, 2019
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #5003 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5003   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files          74       74           
  Lines        2472     2472           
  Branches      608      608           
=======================================
  Hits         2280     2280           
  Misses        172      172           
  Partials       20       20
Impacted Files Coverage 螖
packages/webpack/src/config/base.js 95.45% <酶> (酶) 猬嗭笍
packages/webpack/src/plugins/vue/server.js 84.61% <0%> (-3.85%) 猬囷笍
packages/webpack/src/plugins/vue/client.js 94.28% <0%> (-2.86%) 猬囷笍
packages/vue-renderer/src/renderer.js 95.85% <0%> (+1.03%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8106523...82ba5a5. Read the comment docs.

@manniL manniL requested a review from pi0 February 11, 2019 09:50
@pi0 pi0 merged commit 3997d50 into dev Feb 11, 2019
@pi0 pi0 deleted the feat/webpack-futureEmitAssets branch February 11, 2019 10:42
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants