Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit tests for server module #5154

Merged
merged 18 commits into from
Mar 4, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Mar 4, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team March 4, 2019 14:13
pi0
pi0 previously approved these changes Mar 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #5154 into dev will increase coverage by 0.54%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5154      +/-   ##
=========================================
+ Coverage   96.06%   96.6%   +0.54%     
=========================================
  Files          73      72       -1     
  Lines        2463    2447      -16     
  Branches      625     620       -5     
=========================================
- Hits         2366    2364       -2     
+ Misses         81      68      -13     
+ Partials       16      15       -1
Impacted Files Coverage Δ
packages/server/src/middleware/nuxt.js 100% <ø> (+1.47%) ⬆️
packages/server/src/middleware/error.js 100% <100%> (+2.12%) ⬆️
packages/vue-renderer/src/renderer.js 95.85% <0%> (+1.03%) ⬆️
packages/server/src/listener.js 100% <0%> (+1.88%) ⬆️
packages/server/src/middleware/modern.js 100% <0%> (+3.12%) ⬆️
packages/server/src/middleware/timing.js 100% <0%> (+4.54%) ⬆️
packages/server/src/server.js 100% <0%> (+5.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70047c7...e8c20c4. Read the comment docs.

@clarkdo clarkdo requested a review from pi0 March 4, 2019 16:13
@clarkdo clarkdo merged commit cc573a4 into nuxt:dev Mar 4, 2019
@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the feat/test-server branch April 2, 2019 13:20
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants