Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): fix jest test dependencies #5155

Merged
merged 2 commits into from
Mar 4, 2019
Merged

chore(examples): fix jest test dependencies #5155

merged 2 commits into from
Mar 4, 2019

Conversation

aldarund
Copy link

@aldarund aldarund commented Mar 4, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #5155 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5155   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          73       73           
  Lines        2463     2463           
  Branches      625      625           
=======================================
  Hits         2366     2366           
  Misses         81       81           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52fe145...fc37ef6. Read the comment docs.

@aldarund aldarund requested a review from clarkdo March 4, 2019 19:11
@clarkdo
Copy link
Member

clarkdo commented Mar 4, 2019

Is babel-core for babel-jest? babel-jest 24 has already upgraded to @babel/core

@aldarund
Copy link
Author

aldarund commented Mar 4, 2019

@clarkdo its for vue-jest as i see
https://codesandbox.io/s/github/nuxt/nuxt.js/tree/dev/examples/jest-vtu-example broken without babel-core.

AIL components/Btn/Btn.spec.js
● Test suite failed to run

Cannot find module 'babel-core'

However, Jest was able to find:
    './Btn.spec.js'
    './Btn.vue'

You might want to include a file extension in your import, or update your 'moduleFileExtensions', which is currently ['js', 'json', 'vue'].

See https://jestjs.io/docs/en/configuration#modulefileextensions-array-string

  at Object.<anonymous> (node_modules/vue-jest/lib/compilers/babel-compiler.js:1:15)

@clarkdo
Copy link
Member

clarkdo commented Mar 4, 2019

How about using vue-jest 4.0-beta?

@aldarund
Copy link
Author

aldarund commented Mar 4, 2019

if its stable enough it would be good idea :)

@aldarund
Copy link
Author

aldarund commented Mar 4, 2019

@clarkdo tested, work fine. updated to 4-beta2

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkdo clarkdo merged commit 1c3761a into dev Mar 4, 2019
@clarkdo clarkdo deleted the fix-jest-example branch March 4, 2019 21:07
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants