Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss): default to preset-env and cssnano last #5215

Merged
merged 3 commits into from
Mar 13, 2019

Conversation

manniL
Copy link
Member

@manniL manniL commented Mar 12, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Currently, cssnano is moved at the end of the Postcss plugin chain. This totally makes sense. However, as Nuxt includes postcss-preset-env by default which contains autoprefixer, it should come second last to apply prefixing to all previous plugin outputs (e.g. tailwindcss).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@manniL manniL requested review from pi0 and clarkdo March 12, 2019 22:33
@manniL manniL added the WIP label Mar 12, 2019
@manniL manniL removed the WIP label Mar 12, 2019
@codecov-io
Copy link

Codecov Report

Merging #5215 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5215      +/-   ##
==========================================
+ Coverage   96.28%   96.33%   +0.04%     
==========================================
  Files          73       73              
  Lines        2476     2481       +5     
  Branches      628      629       +1     
==========================================
+ Hits         2384     2390       +6     
+ Misses         77       76       -1     
  Partials       15       15
Impacted Files Coverage Δ
packages/webpack/src/utils/postcss.js 92.59% <100%> (+0.75%) ⬆️
packages/vue-renderer/src/renderer.js 94.89% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37006f6...01c1625. Read the comment docs.

@pi0 pi0 merged commit adf423a into dev Mar 13, 2019
@pi0
Copy link
Member

pi0 commented Mar 13, 2019

Nice find @manniL

@pi0 pi0 deleted the fix/preset-env-and-cssnano-last branch March 13, 2019 10:10
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants