Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fail tests in case of unhandled errors #5255

Merged
merged 7 commits into from
Mar 16, 2019
Merged

test: fail tests in case of unhandled errors #5255

merged 7 commits into from
Mar 16, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 16, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Currently, we have some unhandledPromiseRejections which are uncaught!

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 changed the title tests: fail tests in case of unhandled errors test: fail tests in case of unhandled errors Mar 16, 2019
@codecov-io
Copy link

codecov-io commented Mar 16, 2019

Codecov Report

Merging #5255 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5255      +/-   ##
==========================================
+ Coverage   95.98%   95.99%   +0.01%     
==========================================
  Files          74       74              
  Lines        2490     2497       +7     
  Branches      630      633       +3     
==========================================
+ Hits         2390     2397       +7     
  Misses         84       84              
  Partials       16       16
Impacted Files Coverage Δ
packages/cli/src/command.js 98.97% <100%> (+0.07%) ⬆️
packages/vue-renderer/src/renderer.js 94.38% <0%> (-0.52%) ⬇️
packages/cli/src/commands/generate.js 100% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2561b68...1394b09. Read the comment docs.

@pi0 pi0 marked this pull request as ready for review March 16, 2019 12:17
@pi0 pi0 merged commit d6b505a into dev Mar 16, 2019
@pi0 pi0 deleted the test/error-trap branch March 16, 2019 12:42
@pi0 pi0 mentioned this pull request Mar 16, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants