fix(vue-app): multiple named views cause invalid syntax

[leahciMic]

Fixes #5096

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

• Reset resMap to an empty string before building the list of components
• Add another.vue which fails the build if the bug is present (as the
  resulting .nuxt/router.js will contain a syntax error)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[robertpiosik]

Faced this issue till the morning, trying to find out a solution and just came across this PR. Simple solution, working as expected 👏

I can't believe that named views was released in stable with such a bug 👀

As you changed "test/fixtures/named-views/nuxt.config.js" file; used filter method on routes will remove those which not satisfy ones in passed function, what breaks autogenerated router configuration. Am I wrong? Correct me if so

[codecov-io]

Codecov Report

Merging #5262 into dev will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #5262      +/-   ##
==========================================
+ Coverage   95.95%   95.99%   +0.04%     
==========================================
  Files          74       74              
  Lines        2499     2499              
  Branches      634      634              
==========================================
+ Hits         2398     2399       +1     
+ Misses         85       84       -1     
  Partials       16       16

Impacted Files	Coverage Δ
packages/vue-renderer/src/renderer.js	94.89% <0%> (+0.51%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1ecf0...18f973c. Read the comment docs.

[leahciMic]

@robertpiosik

Faced this issue till the morning, trying to find out a solution and just came across this PR. Simple solution, working as expected 👏

Thank you for confirming this fixes the issue!

I can't believe that named views was released in stable with such a bug 👀

These things happen!

As you changed "test/fixtures/named-views/nuxt.config.js" file; used filter method on routes will remove those which not satisfy ones in passed function, what breaks autogenerated router configuration. Am I wrong? Correct me if so

I believe you can return a new array from extendRoutes that will replace the routes, but in this case we only modify some of the objects in the array. filter itself does not mutate the array, so it will not drop any routes.

[manniL]

Thanks so far! Left you some comments ☺️

[leahciMic]

@manniL thank you for your review, I have addressed the feedback

[manniL]

LGTM ☺️

[manniL]

#5096 (comment) <- 🤔

[leahciMic]

@manniL I have looked at that comment, I believe there was some confusion as to how to test it. He has checked out my dev branch of nuxt which is very much out-of-date. I'm clearing up the instructions for him on how to test it.