Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ts): add warning for nuxt-ts deprecation #5301

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

kevinmarrec
Copy link
Contributor

Screenshot from 2019-03-20 20-08-40

@kevinmarrec kevinmarrec changed the title refactor: add warning for nuxt-ts deprecation refactor(ts): add warning for nuxt-ts deprecation Mar 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #5301 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5301      +/-   ##
=========================================
+ Coverage   95.66%   95.7%   +0.03%     
=========================================
  Files          74      74              
  Lines        2513    2513              
  Branches      639     639              
=========================================
+ Hits         2404    2405       +1     
+ Misses         92      91       -1     
  Partials       17      17
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 92.07% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665f15a...e25ca02. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #5301 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5301   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          74       74           
  Lines        2513     2513           
  Branches      639      639           
=======================================
  Hits         2404     2404           
  Misses         92       92           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665f15a...d014a34. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Mar 20, 2019

Damn! It's so sexy

pi0
pi0 previously approved these changes Mar 20, 2019
@pi0 pi0 merged commit a11afd4 into nuxt:dev Mar 21, 2019
@pi0 pi0 mentioned this pull request Mar 21, 2019
@kevinmarrec kevinmarrec deleted the deprecate-nuxt-ts branch March 22, 2019 00:29
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants