Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): always resolve core-js to v3 #5307

Merged
merged 2 commits into from
Mar 21, 2019
Merged

fix(webpack): always resolve core-js to v3 #5307

merged 2 commits into from
Mar 21, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 21, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

@babel/polyfill translates : var b = new Map(); into import "core-js/modules/es6.map"; var b = new Map(); thus webpack tries to require node_modules/core-js. In case of package-manager hoists core-js@2 in node_modules and moves core-js@3 to node_modules/@nuxt/babel-preset-app/node_modules we will get into trouble. This PR forces webapck to correctly resolve from correct version of core-js.

Fixes nuxt-community/pwa-module#170

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from clarkdo and a team March 21, 2019 11:10
@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #5307 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5307      +/-   ##
=========================================
+ Coverage   95.66%   95.7%   +0.03%     
=========================================
  Files          74      74              
  Lines        2513    2513              
  Branches      639     639              
=========================================
+ Hits         2404    2405       +1     
+ Misses         92      91       -1     
  Partials       17      17
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 95.5% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 92.07% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46def7...8a3a76d. Read the comment docs.

@pi0 pi0 merged commit 65c1f86 into dev Mar 21, 2019
@manniL manniL deleted the fix/core-js branch March 21, 2019 11:56
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

corejs issues
3 participants