Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove consola.debug for hooks #5318

Merged
merged 3 commits into from Mar 21, 2019
Merged

fix: remove consola.debug for hooks #5318

merged 3 commits into from Mar 21, 2019

Conversation

HapLifeMan
Copy link

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Starting on Nuxt 2.5.x with the loading screen, this line causes spamming with bundler:progress calls.
The consequence to this is delaying the build time from seconds to minutes. I think it's an oversight.

Checklist:

  • not applicable My change requires a change to the documentation.
  • not applicable I have updated the documentation accordingly. (PR: #)
  • not applicable I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Starting on Nuxt 2.5.x with the loading screen, this line causes spamming with bundler:progress.
The consequence to this is delaying the build time from seconds to minutes.
I think it's an oversight.
@pi0 pi0 changed the title Removed consola.debug fix: remove consola.debug for hooks Mar 21, 2019
aldarund
aldarund previously approved these changes Mar 21, 2019
@aldarund aldarund self-requested a review March 21, 2019 19:40
@pi0
Copy link
Member

pi0 commented Mar 21, 2019

Tests fixed. Waiting for CI

@pi0 pi0 merged commit 9ff01f9 into nuxt:dev Mar 21, 2019
@HapLifeMan HapLifeMan deleted the HapLifeMan-patch-1 branch March 21, 2019 19:54
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants