Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply default lock options before setting lock #5320

Merged
merged 1 commit into from Mar 21, 2019

Conversation

pimlie
Copy link

@pimlie pimlie commented Mar 21, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

As second / third time is the charm, now not only relax the lock settings but also really use them. Sorry 馃槉

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Fixes: #5319

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #5320 into dev will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #5320      +/-   ##
=========================================
- Coverage   95.7%   95.66%   -0.04%     
=========================================
  Files         74       74              
  Lines       2512     2514       +2     
  Branches     639      639              
=========================================
+ Hits        2404     2405       +1     
- Misses        91       92       +1     
  Partials      17       17
Impacted Files Coverage 螖
packages/utils/src/locking.js 100% <100%> (酶) 猬嗭笍
packages/vue-renderer/src/renderer.js 91.58% <0%> (-0.5%) 猬囷笍
packages/core/src/hookable.js 100% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3153e89...abd7fb8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker is no longer able to execute 'nuxt build' - Unable to update lock within the stale threshold
4 participants