New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add type definition for typescript.typeCheck #5326
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5326 +/- ##
====================================
Coverage 96% 96%
====================================
Files 74 74
Lines 2529 2529
Branches 640 640
====================================
Hits 2428 2428
Misses 85 85
Partials 16 16 Continue to review full report at Codecov.
|
I can also provide more precise types from fork-ts-checker docs if that would be helpful, but we'd then need to keep them in sync. I don't think they currently export the Config type, though it is present in the built npm module. |
Thanks for your PR @danielroe ! I suggested a little change. And for the type of the options of ForkTsChecker, there is IMO too many properties to stay in sync, I prefer see if we can import the types from somewhere, or see with the maintainer how we could have them. |
Co-Authored-By: danielroe <daniel@concision.co.uk>
Co-Authored-By: danielroe <daniel@concision.co.uk>
Thanks @danielroe @kevinmarrec ❤️ |
Types of changes
Description
Added type definition for NuxtConfiguration for new
build.typescript
option.TypeScript validation was failing with new configuration model.
Checklist: