Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add type definition for typescript.typeCheck #5326

Merged
merged 5 commits into from Mar 24, 2019
Merged

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added type definition for NuxtConfiguration for new build.typescript option.

TypeScript validation was failing with new configuration model.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #5326 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #5326   +/-   ##
====================================
  Coverage    96%     96%           
====================================
  Files        74      74           
  Lines      2529    2529           
  Branches    640     640           
====================================
  Hits       2428    2428           
  Misses       85      85           
  Partials     16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77dcfe6...847f2f1. Read the comment docs.

@danielroe
Copy link
Member Author

I can also provide more precise types from fork-ts-checker docs if that would be helpful, but we'd then need to keep them in sync. I don't think they currently export the Config type, though it is present in the built npm module.

packages/config/types/build.d.ts Outdated Show resolved Hide resolved
@kevinmarrec
Copy link
Contributor

kevinmarrec commented Mar 23, 2019

Thanks for your PR @danielroe !

I suggested a little change. And for the type of the options of ForkTsChecker, there is IMO too many properties to stay in sync, I prefer see if we can import the types from somewhere, or see with the maintainer how we could have them.

@pi0 pi0 changed the title fix: add type definition for configuring forkTsChecker fix(types): add type definition for typescript.typeCheck Mar 23, 2019
packages/config/types/build.d.ts Outdated Show resolved Hide resolved
kevinmarrec and others added 2 commits March 23, 2019 14:06
Co-Authored-By: danielroe <daniel@concision.co.uk>
Co-Authored-By: danielroe <daniel@concision.co.uk>
packages/config/types/build.d.ts Outdated Show resolved Hide resolved
@pi0 pi0 added pending and removed pending labels Mar 23, 2019
@pi0 pi0 merged commit 565c0d1 into nuxt:dev Mar 24, 2019
@pi0
Copy link
Member

pi0 commented Mar 24, 2019

Thanks @danielroe @kevinmarrec ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants