New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript): detect typescript based on tsconfig.json #5412
Conversation
We have to highlight that change in the release notes (as done before with changes on experimental features) |
@manniL Sure. Actually it is a complement of #5367. New migration guide would be:
Nuxt 2.5 users may only require to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work @pi0 !!!
So I guess we can close nuxt/docs#1269 (which was linked to #5367 ) and start from current docs https://nuxtjs.org/guide/typescript to just add the ts-node
thing ?
Migration guide for 2.5.x projects should be just installing |
@pi0 |
@kevinmarrec Migration guide updated. Does it looks good now? (Feel free editing my comment).
For lazy people who only install |
@pi0 perfect Yeah I see, but if it's not used anymore within this package, we probably should remove it ? |
@kevinmarrec Done. Dependency removed and guide updated. I had to add |
Alright perfect @pi0, worth mentionning that the guide is applicable for Don't know how exactly we're gonna wrap it up in release notes but yeah 🙈 |
Codecov Report
@@ Coverage Diff @@
## dev #5412 +/- ##
==========================================
+ Coverage 96.17% 96.17% +<.01%
==========================================
Files 74 74
Lines 2534 2539 +5
Branches 644 646 +2
==========================================
+ Hits 2437 2442 +5
Misses 81 81
Partials 16 16
Continue to review full report at Codecov.
|
registerTSNode
from@nuxt/typescript
into@nuxt-cli
. This way users can keep@nuxt-typescript
(~55.2 MB) intodevDependencies
andts-node
(1.6 MB) independencies
. This means much less production install size and also have runtime support.cli/imports.js
for better maintenance.tsconfig.json
exists in therootDir
.tsconfig.json
is empty JSON, defaults will be written into it by@nuxt/typescript
.