Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update members in license and package.json #5498

Merged
merged 3 commits into from
Apr 9, 2019
Merged

chore: update members in license and package.json #5498

merged 3 commits into from
Apr 9, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Apr 9, 2019

No description provided.

@clarkdo clarkdo requested a review from a team April 9, 2019 12:56
@codecov-io
Copy link

codecov-io commented Apr 9, 2019 •
edited

Codecov Report

Merging #5498 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5498      +/-   ##
==========================================
+ Coverage   96.09%   96.13%   +0.03%     
==========================================
  Files          74       74              
  Lines        2563     2563              
  Branches      652      652              
==========================================
+ Hits         2463     2464       +1     
+ Misses         84       83       -1     
  Partials       16       16
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 95.6% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59a794...f6a8d87. Read the comment docs.

kevinmarrec
kevinmarrec suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarkdo -> @aldarund was also missing in LICENSE file 😁

@clarkdo clarkdo requested a review from kevinmarrec April 9, 2019 13:19
@pi0 pi0 merged commit 9831943 into nuxt:dev Apr 9, 2019
@pi0 pi0 mentioned this pull request Apr 12, 2019
Merged
@clarkdo clarkdo deleted the member-license branch April 23, 2019 09:26
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@kevinmarrec kevinmarrec kevinmarrec approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@clarkdo @codecov-io @pi0 @kevinmarrec @danielroe