Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): add type definition for functional babel.presets #5785

Merged
merged 5 commits into from
May 22, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 22, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from pi0 and kevinmarrec May 22, 2019 13:01
@clarkdo clarkdo changed the title fix(ts): add function babel.presets type definition fix(ts): add functional babel.presets type definition May 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #5785 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5785   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          82       82           
  Lines        2662     2662           
  Branches      682      682           
=======================================
  Hits         2546     2546           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62585f...8046e3c. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #5785 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5785   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          82       82           
  Lines        2662     2662           
  Branches      682      682           
=======================================
  Hits         2546     2546           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62585f...3a6e405. Read the comment docs.

@clarkdo clarkdo changed the title fix(ts): add functional babel.presets type definition fix(ts): add type definition for functional babel.presets May 22, 2019
packages/config/types/build.d.ts Outdated Show resolved Hide resolved
packages/config/types/build.d.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants