Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(builder): pass nuxt options to template as nuxtOptions #5792

Merged
merged 4 commits into from
May 23, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 23, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes: #5783
Related to #5730

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 May 23, 2019 08:05
@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #5792 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5792   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          82       82           
  Lines        2662     2662           
  Branches      682      682           
=======================================
  Hits         2546     2546           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.59% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/builder/src/builder.js 100% <ø> (ø) ⬆️
packages/builder/src/context/template.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59071e4...8b78986. Read the comment docs.

@clarkdo clarkdo requested a review from pi0 May 23, 2019 08:25
pi0
pi0 previously approved these changes May 23, 2019
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkdo clarkdo changed the title feat(builder): pass nuxt options to template as nuxtOptions refactor(builder): pass nuxt options to template as nuxtOptions May 23, 2019
Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pi0 pi0 merged commit 737d5f0 into nuxt:dev May 23, 2019
@pi0
Copy link
Member

pi0 commented May 23, 2019

For docs, I suggest keeping this new (feature) as undocumented. In any stage, we may change the config interface in an incompatible way and this may break users. Maybe we can suggest always cherry-picking needed options into template options param when needed.

@clarkdo
Copy link
Member Author

clarkdo commented May 23, 2019

@pi0 Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: /.nuxt/nuxt-icons.js: Unexpected token, expected "," (93:1387)
5 participants