Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-renderer): add vary header for user-agent in modern server mode #5807

Merged
merged 2 commits into from May 25, 2019
Merged

fix(vue-renderer): add vary header for user-agent in modern server mode #5807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7181e5f
fix(vue-renderer): add Vary header for server mode
May 25, 2019
e6a7369
test: add test for vary user-agent
May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/vue-renderer/src/renderers/modern.js
View file
Open in desktop
Expand Up @@ -109,4 +109,12 @@ export default class ModernRenderer extends SSRRenderer {
return linkTag.replace('rel="preload"', `rel="modulepreload"${cors}`).replace(legacyJsFile, modernJsFile)
})
}

async render(renderContext) {
const result = await super.render(renderContext)
if (this.isServerMode) {
renderContext.res.setHeader('Vary', 'User-Agent')
}
return result
}
}
8 changes: 8 additions & 0 deletions test/unit/modern.server.test.js
View file
Open in desktop
Expand Up @@ -68,6 +68,14 @@ describe('modern server mode', () => {
].join(', '))
})

test('Vary header should contain User-Agent', async () => {
const { headers: { vary } } = await rp(url('/'), {
resolveWithFullResponse: true,
headers: { 'user-agent': modernUA }
})
expect(vary).toContain('User-Agent')
})

// Close server and ask nuxt to stop listening to file changes
afterAll(async () => {
await nuxt.close()
Expand Down