Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): clone options.head before generating meta tags in spa mode #6429

Merged
merged 1 commit into from Sep 17, 2019

Conversation

pimlie
Copy link

@pimlie pimlie commented Sep 17, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #6428

vue-meta mutates the metaInfo object it receives, which could cause issues as in the linked issue.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #6429 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6429   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          79       79           
  Lines        2689     2689           
  Branches      694      694           
=======================================
  Hits         2571     2571           
  Misses        101      101           
  Partials       17       17
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.79% <0%> (ø) ⬆️
#unit 92.26% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/spa.js 87.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0149d...6ce21ea. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Sep 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

titleTemplate is not working properly and repeats itself multiple times
4 participants