Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-app): use loose mode for babel class plugin #6435

Merged
merged 1 commit into from Sep 20, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Sep 18, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix nuxt-start issue from @aldarund , as class plugin is the only builtin plugin of @nuxt/babel-preset-app, so use loose mode for avoiding unnecessary babel runtime helper.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo changed the title Class loose fix: use loose mode for babel class plugin Sep 18, 2019
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #6435 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #6435   +/-   ##
=====================================
  Coverage   95.6%   95.6%           
=====================================
  Files         79      79           
  Lines       2684    2684           
  Branches     692     692           
=====================================
  Hits        2566    2566           
  Misses       101     101           
  Partials      17      17
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.7% <ø> (ø) ⬆️
#unit 92.28% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/babel-preset-app/src/index.js 96.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b31553...5d89e01. Read the comment docs.

@pi0 pi0 changed the title fix: use loose mode for babel class plugin fix(babel-preset-app): use loose mode for babel class plugin Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants