test: use got instead of request
#6740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like issue still persists, let's continue to observe and investigate. |
|
I disabled |
|
Update: Test is failed event in v2.8.0 and only happened in Node.js 13.2.0 |
|
Update: Looks like it's related to vue renderer |
clarkdo
changed the title
|
@clarkdo In any case, switching to |
pi0
changed the title
got instead of request
Merged
This was referenced Mar 20, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you may already notice, the tests are failing randomly recently.
From node 13.2, the condition becomes even worse, CI is 100% failing now.
Through my investigation, it's related to
requestlib, it seemed that there is reference leak and race condition, so this pr is gonna replace it withgot