Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): upgrade html-webpack-plugin to v4 #7119

Merged
merged 11 commits into from
May 7, 2020
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Mar 23, 2020

No description provided.

@pi0
Copy link
Member

pi0 commented Mar 23, 2020

Changelog: https://github.com/jantimon/html-webpack-plugin/blob/master/CHANGELOG.md#400-2020-03-23

Probably too soon to update in minor version. I would suggest waiting few days to ensure no regressions or merging to next.

@clarkdo
Copy link
Member Author

clarkdo commented May 7, 2020

@pi0 Is this OK now ? Latest version has been 4.3.0.

pi0
pi0 previously approved these changes May 7, 2020
@codecov-io
Copy link

codecov-io commented May 7, 2020

Codecov Report

Merging #7119 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7119   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files          84       84           
  Lines        3431     3431           
  Branches      943      943           
=======================================
  Hits         2447     2447           
  Misses        794      794           
  Partials      190      190           
Flag Coverage Δ
#unittests 71.32% <0.00%> (ø)
Impacted Files Coverage Δ
packages/webpack/src/config/client.js 67.10% <ø> (ø)
packages/webpack/src/plugins/vue/modern.js 3.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37c3d4...2b609d8. Read the comment docs.

@clarkdo clarkdo merged commit 789f0e6 into dev May 7, 2020
@clarkdo clarkdo deleted the html-webpack-plugin-v4 branch May 7, 2020 10:52
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants