Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(babel-preset-app): add bugfixes option #7144

Merged
merged 1 commit into from
Mar 30, 2020
Merged

feat(babel-preset-app): add bugfixes option #7144

merged 1 commit into from
Mar 30, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Mar 27, 2020 •
edited

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Related to #6784 (comment)

Add new option bugfixes which is introduced from babel-preeset-env 7.9.0.

Options can be set by:

export default {
  build: {
    babel: {
      presets: ['@nuxt/babel-preset-app', { bugfixes: true }]
  }
}

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo mentioned this pull request Mar 27, 2020
Closed
@clarkdo clarkdo requested a review from a team March 27, 2020 15:18
pi0
pi0 reviewed Mar 27, 2020
View reviewed changes
packages/babel-preset-app/src/index.js
@@ -55,6 +55,7 @@ module.exports = (api, options = {}) => {
const envName = api.env()

const {
bugfixes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of setting explicit default value here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping same default value as babel make it default true until babel 8 is proper.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add false to it. And change to true when upgrade to babel 8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both LGTM. I let you decide state to merge :)

@pi0 pi0 changed the title feat(babel): add bugfixes option in babel-preset-app feat(babel-preset-app): add bugfixes option Mar 27, 2020
@clarkdo clarkdo merged commit 728ab88 into dev Mar 30, 2020
@clarkdo clarkdo deleted the feat/babel-preset-bugfixes branch March 30, 2020 09:49
@pi0 pi0 mentioned this pull request Apr 26, 2020
Closed
@pi0 pi0 mentioned this pull request Jun 10, 2020
Merged
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clarkdo @pi0 @danielroe