Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): not override presets if babelrc is true #7297

Merged
merged 1 commit into from
May 1, 2020
Merged

fix(babel): not override presets if babelrc is true #7297

merged 1 commit into from
May 1, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 1, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Related to #7291

If babel.babelrc is true, it means user will use .babelrc to config babel option, so we shouldn't override presets, we've ignore the override for babel.configFile, this pr is applying same logic to babel.babelrc

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team May 1, 2020 12:06
@clarkdo clarkdo self-assigned this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants