Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modern): remove inlined safari fix in csp mode #7306

Merged
merged 3 commits into from
May 3, 2020
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 3, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Idea is from vuejs/vue-cli#2741
Related issue: #4876

If csp is enabled without unsafe-inline, let's inject safari no-module fix as an external script.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team May 3, 2020 12:17
@codecov-io
Copy link

codecov-io commented May 3, 2020

Codecov Report

Merging #7306 into dev will decrease coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7306      +/-   ##
==========================================
- Coverage   62.87%   62.59%   -0.28%     
==========================================
  Files          84       84              
  Lines        3410     3425      +15     
  Branches      932      937       +5     
==========================================
  Hits         2144     2144              
- Misses       1018     1028      +10     
- Partials      248      253       +5     
Flag Coverage Δ
#unittests 62.59% <0.00%> (-0.28%) ⬇️
Impacted Files Coverage Δ
packages/webpack/src/config/client.js 0.00% <0.00%> (ø)
packages/webpack/src/plugins/vue/modern.js 3.77% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3ff4d...276b70a. Read the comment docs.

pi0
pi0 previously approved these changes May 3, 2020
@clarkdo
Copy link
Member Author

clarkdo commented May 3, 2020

Is it necessary for CSP to not inline scripts?

I think inline scripts is restricted by most csp users as it's safer.

And this pr is only user who are using all of spa, modern and csp users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants